Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db wait logic #2706

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Fix db wait logic #2706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fallback for ibis drop table
- Add create events waiting on db apply.
- Refactor secrets loading method.
- Add db.load in db wait

#### New Features & Functionality

Expand Down
4 changes: 2 additions & 2 deletions superduper/base/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ def apply(


def _wait_on_events(db, events):
remaining = len(events)
time_left = _WAIT_TIMEOUT
while True:
remaining = len(events)
for event in events:
identifier = event.component['identifier']
type_id = event.component['type_id']
version = event.component['version']
try:
db.show(type_id=type_id, identifier=identifier, version=version)
db.load(type_id=type_id, identifier=identifier, version=version)
except FileNotFoundError:
pass
else:
Expand Down
Loading