Add secrets reload withs safe retry #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blythed
reviewed
Dec 26, 2024
| self.syncClient = SyncOpenAI(**self.client_kwargs) | ||
|
|
||
| if 'OPENAI_API_KEY' not in os.environ and ( | ||
| 'api_key' not in self.client_kwargs.keys() and self.client_kwargs | ||
| ): | ||
| raise ValueError( | ||
| raise exceptions.SecretsMissingException( |
blythed
reviewed
Dec 26, 2024
superduper/base/config.py
Outdated
| @@ -174,6 +174,7 @@ class Config(BaseConfig): | |||
| envs: dc.InitVar[t.Optional[t.Dict[str, str]]] = None | |||
|
|
|||
| data_backend: str = "mongodb://localhost:27017/test_db" | |||
| secret_dir: str = os.path.join(".superduper", "secrets") | |||
blythed
requested changes
Dec 26, 2024
superduper/base/config.py
Outdated
| @@ -174,6 +174,7 @@ class Config(BaseConfig): | |||
| envs: dc.InitVar[t.Optional[t.Dict[str, str]]] = None | |||
|
|
|||
| data_backend: str = "mongodb://localhost:27017/test_db" | |||
| secret_dir: str = os.path.join(".superduper", "secrets") | |||
kartik4949
force-pushed
the
add/secrets_reload
branch
from
db35354 to
9f2007c
Compare
kartik4949
force-pushed
the
add/secrets_reload
branch
13 times, most recently
from
ddb1e0c to
7ef935f
Compare
blythed
reviewed
Dec 27, 2024
| @@ -1,5 +1,5 @@ | |||
| from .model import OpenAIChatCompletion, OpenAIEmbedding | |||
|
|
|||
| __version__ = "0.4.2" | |||
| __version__ = "0.4.3" | |||
blythed
approved these changes
Dec 27, 2024
kartik4949
force-pushed
the
add/secrets_reload
branch
from
7ef935f to
2be19ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments