-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade issues templates #11
base: main
Are you sure you want to change the base?
Conversation
validations: | ||
required: true | ||
|
||
- type: dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right that the user has to specify a runtime? The issue might not even related to it, but rather the supabase dashboard or some api repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, i tried to keep the templates that were there, so that only the style changes, and potentially add other information (such as the choice of runtime).
Do you think we should modify these new templates so that they are more representative of Supabase's work? Including, for example, a dropdown to choose what the issue is about (supabase-js, supabase-flutter....)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on where the template gets applied to. In the flutter repos, we currently have our own issue templates. All flutter related issues should be collected there and not in the supabase/supabase repo. So I don't think it makes sense to add a client library dropdown. I think the template here should be very general. Repository specific information should be specified in a template per repository. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, pushing an update asap
validations: | ||
required: false | ||
|
||
- type: input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below. Not all issues have to do with supabase-js
What kind of change does this PR
This pull request upgrade issues templates.
What is the current behavior?
The current system works. At the same time, users can change the information as they wish, and potentially leave out some of the requested information. This is not possible with this new template system.
It also adds a
triage
label interaction to make the issue triage easier. This is another idea, and can be removed if you prefer.What is the new behavior?
Before
After
Additional context
Please let me know if you think it's a good idea, and if so, if i should do the same for other repositories.