Improve equirect_facetype docs; fix pretty insignificant rounding issue. #35
Conversation
|
@BrianPugh Can you tell me more about the rounding issue? I came across something similar in my PyTorch version: ProGamerGov/pytorch360convert#5 |
|
Actually never mind, I see the issue here is slightly different to the linspace rounding. |
|
This was just fixing a double/rounding/truncation thing that has minimal impact; i'll look at your PR to see if there could be some good cross-pollination. |
|
@BrianPugh Awesome, thanks! Let me know if you notice any other issues present in my code as well. There are a few notable differences like autograd compatibility, device types, and potential JIT usage (lots of extra type hints/asserts that mypy also likes), but I'm trying to follow the original code base to ensure accuracy for researchers. |
|
@BrianPugh If you're looking for cross pollination ideas, I've added new features to pytorch360convert like the e2e function for modifying rectangular tensors, and the 'stack' cube format: https://github.com/ProGamerGov/pytorch360convert/ |
|
ooo that's a good idea! would prevent the reaching in of using functions from utils. |
No description provided.