e2c and c2e tests; fix flipped image issue mentioned in #11 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
BrianPugh
force-pushed
the
bugfix/flip
branch
from
9a4f2b9 to
17070b8
Compare
BrianPugh
force-pushed
the
bugfix/flip
branch
from
17070b8 to
6adfef0
Compare
Closed
Closed
|
@BrianPugh were these the only changes you made to correct the face orientation? |
Correct |
|
@BrianPugh I tried copying these changes with my pytorch code, but confusingly the problem still remains. |
|
@BrianPugh I've been playing around with it for a bit, but I might actually need your help in figuring it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the solution posted by @zafirshi in #11. For this to fully work other spurious flips in the codebase have to be removed, which cleans things up nicely.
Certainly a breaking-change-bugfix.
Honorable mention: @moonpyx