Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SFC reference, update to current version of our blurb #81

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pikurasa
Copy link

No description provided.

@pikurasa pikurasa requested a review from srevinsaju as a code owner October 18, 2024 14:19
@pikurasa
Copy link
Author

This only changes the text in the footer, and, I expect, would have no impact on how the code is run. So I don't know why the test would fail. Maybe these tests need to be updated? Or the code needs to be updated?

@quozl quozl merged commit 266bea9 into master Oct 18, 2024
0 of 3 checks passed
@quozl
Copy link
Contributor

quozl commented Oct 18, 2024

I agree, not a reason not to merge.

@srevinsaju, @chimosky any ideas? Does anything have to be done to the automation?

@srevinsaju
Copy link
Member

Nothing blocking the merge. The actions are failing due to new formatting rules from black, which wasn't pinned to a specific version - and another test is failing trying to get a translation file from an XO if I understand correctly. We can merge this PR. Deployment is manual on sunjammer, and it shouldn't cause any errors there.

@pikurasa pikurasa deleted the update-footer branch October 19, 2024 15:48
@pikurasa
Copy link
Author

Thanks.

Perhaps we can write a new issue for fixing the test failing.

@chimosky
Copy link
Member

Thanks.

Perhaps we can write a new issue for fixing the test failing.

This sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants