refactor: Breaks out zipping blocks into a function #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using this short, tested function. Tests will fail as this is a stacked pull request and was branched off of `ns-rse/89-assigned-utrons` where the underlying differences are under investigation. Once resolved may need to rebase this branch to absorb any fixes/resolutions.
<istakenly ammended previous commit so it contains the fix itself, but this commit fixes the lengths in the tests (which are now derived from `query_length` as they should be and _not_ the `reference_length`). These are consistently `150` now for the samples selected at present (but will be updated with more samples in #131).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90