fixup! Add PriorityQueue

submariner-io · Jan 25, 2025 · 1497d90 · 1497d90
1 parent 8d9628f
commit 1497d90
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/workqueue/priority_queue.go b/pkg/workqueue/priority_queue.go
@@ -85,14 +85,17 @@ func (p *PriorityQueue) SetPriority(item any, priority int) {
 	var priorityItem priorityType
 	priorityItem.priority = priority
 
-	existing, found := p.priorities.Load(item)
+	v, found := p.priorities.Load(item)
 	if !found {
 		p.priorities.LoadOrStore(item, priorityItem)
 
 		return
 	}
 
-	if existing.(priorityType).priority != priority {
+	existing := v.(priorityType)
+	priorityItem.dirty = existing.dirty
+
+	if existing.priority != priority {
 		priorityItem.dirty = true
 	}
 

diff --git a/pkg/workqueue/priority_queue_test.go b/pkg/workqueue/priority_queue_test.go
@@ -64,6 +64,7 @@ var _ = Describe("PriorityQueue", func() {
 		push("third", 1)
 
 		pq.SetPriority("second", 20)
+		pq.SetPriority("second", 20) // should be a no-op
 		pq.Adjust("second")
 		pq.Adjust("second") // should be a no-op
 		Expect(heap.Pop(pq)).To(Equal("second"))