Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

[fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (#20361) #5932

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (#20361) #5932

merged 1 commit into from
Oct 19, 2023

Conversation

liangyepianzhou
Copy link

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@liangyepianzhou liangyepianzhou merged commit 5f6ed1b into streamnative:branch-2.10.5.5-5ce22c Oct 19, 2023
@liangyepianzhou
Copy link
Author

Test liangyepianzhou#3

liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5939)
b67024d 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5941)
17b26e7 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Oct 25, 2023
@liangyepianzhou
Topic properties support for update and remove (#5943)
3523c72 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
liangyepianzhou added a commit that referenced this pull request Dec 13, 2023
@liangyepianzhou
Topic properties support for update and remove (#5979)
a0d4c7d 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
liangyepianzhou added a commit that referenced this pull request Dec 14, 2023
@liangyepianzhou
[fix][broker] managedLedger.getConfig().getProperties().putAll(proper…
3b7cfbb 
…ties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)
liangyepianzhou added a commit that referenced this pull request Dec 14, 2023
@liangyepianzhou
Topic properties support for update and remove (#5981)
6bed83b 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
poorbarcode pushed a commit that referenced this pull request Feb 3, 2024
@liangyepianzhou @poorbarcode
Topic properties support for update and remove (#5981)
b31cf2e 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 12, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981)
d00b88a 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 12, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981) (#6058)
2b83e05 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 13, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981)
3a7b2f8 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
liangyepianzhou added a commit that referenced this pull request Mar 13, 2024
@liangyepianzhou
Topic properties support for update and remove (#5981) (#6062)
ec025cc 
* Topic properties support for update and remove (#5911)

(cherry picked from commit 6d7dfcf)
(cherry picked from commit 6564e6e)
(cherry picked from commit bc7ee1a)
(cherry picked from commit 403aafe)

* [fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE (apache#20361) (#5932)

(cherry picked from commit aa7decc)

Co-authored-by: Heesung Sohn <[email protected]>
(cherry picked from commit 5f6ed1b)
(cherry picked from commit 8765134)
(cherry picked from commit f6e3643)

* Revert gpg and delete useless file

(cherry picked from commit 2739f2c)
(cherry picked from commit 73b7c06)
(cherry picked from commit 2eb4139)
(cherry picked from commit 6bed83b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangyepianzhou @heesung-sn