[SNOW-1887437] Pass query params to snowflake trial signup page link #1220
Conversation
| href={{ pathname: link || "/", query: router.query }} | ||
| className={classNames("not-link", styles.Link)} | ||
| > | ||
| {/*<Link href={link || "/"} className={classNames("not-link", styles.Link)}>*/} |
There was a problem hiding this comment.
todo: remove
|
I changed it a little bit since I didn't want the instructions from the tutorial to be included with the component. I renamed the component to SnowflakeTrial and reduced it to just handling the link, with the option to set the link text. That way, the tutorial page is more readable and won't break if I need to reword it. Does that work for you? Also, where are we linking from? The in-app workflow goes straight to the tutorial signup and "Learn more" goes to another doc page. The other links from cloud also seem to go to that other doc page. I'm not sure that query links are preserved in the router. If I go to |
📚 Context
For the convert to snowflake project we'd like to be able to dynamicaly set the utm_content marketing query param for the
Go to snowflakelink. Right know it's always-ss-streamlit-docs. After the change we would be able to set a different param for OOR email or the Cloud app limits settingsTesting:
Streamlit in SnowflaketileGo to signup.snowflake.comlinkPreview
https://deploy-preview-1220--streamlit-docs.netlify.app/deploy/snowflake?utm_content=ss-streamlit-cloud-settings
Verified with @sfc-gh-atoader if we're fine with this approach from the security perspective
🧠 Description of Changes
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
💥 Impact
Size:
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.