test(listconnectionwithtotalcount): check the number of SQL queries when only fetching totalCount

[euriostigue]

The ListConnectionWithTotalCount always requires 2 queries, even if the edges or pageInfo aren't queried. Ideally, this only requires 1 SQL query.

Description

The required fix will be in the strawberry library. I will be submitting a PR for that shortly. I have added tests here that will pass after those changes have merged and this library uses the latest release.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

#397

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[sourcery-ai]

Hey @euriostigue - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[bellini666]

Hey @euriostigue ,

Yes, you got a point. We won't trigger an extra query for totalCount when only retrieving edges, but the opposite does happen.

Please mark me as a reviewer on strawberry's PR and I'll try to review it ASAP. Let me know if you need help with anything :)

[bellini666]

Hey @euriostigue ,

Yes, you got a point. We won't trigger an extra query for totalCount when only retrieving edges, but the opposite does happen.

Please mark me as a reviewer on strawberry's PR and I'll try to review it ASAP. Let me know if you need help with anything :)

nvm my comment, already reviewed it in strawberry-graphql/strawberry#3480

[euriostigue]

@bellini666 I upgraded the strawberry version and the added test passes now

[bellini666]

@bellini666 I upgraded the strawberry version and the added test passes now

Nice, thank you! 😊