fix: Add support for generated enums in mutation input #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @cngai - Here's my review!
General suggestions:
- Consider adding more comprehensive tests to cover edge cases, especially where enum values might require further parsing or validation.
- Review the handling of Enums in other parts of the codebase to ensure consistency with this new approach.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
|
Hey @bellini666 - would you mind giving this PR a review when you get the chance? Really appreciate it! |
bellini666
force-pushed
the
fix/generated_enums_in_mutations
branch
from
11068f1 to
f624d12
Compare
bellini666
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 87.97% 87.98% +0.01%
==========================================
Files 37 37
Lines 3184 3187 +3
==========================================
+ Hits 2801 2804 +3
Misses 383 383 ☔ View full report in Codecov by Sentry. |
bellini666
approved these changes
Mar 16, 2024
|
Thanks @bellini666 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
GENERATE_ENUMS_FROM_CHOICESis set toTrue, mutations with enum input values will resolve the input type as an enum. When the input is parsed, it tries to save the field as an enum instead of a string value, causing Django to throw a ValidationError"Value 'ExampleEnum.VALUE' is not a valid choice.". This PR addresses this issue by parsing the enum and returning the enum value.Types of Changes
Issues Fixed or Closed by This PR
Fix #491
Checklist