Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase token slot area for V2 pools #3745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase token slot area for V2 pools #3745

wants to merge 1 commit into from
+116 −122

Conversation

jbaublitz
Copy link
Member

No description provided.

@jbaublitz jbaublitz self-assigned this Jan 21, 2025
@packit-as-a-service Packit-as-a-Service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3745
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

mulkieran
mulkieran requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the post-test check failure should be fixed by substituting crypt_metadata_size(DEFAULT_CRYPT_METADATA_SIZE_V2).sectors() for SIZE_OF_CRYPT_METADATA_SECTORS in https://github.com/stratis-storage/stratisd/blob/master/src/engine/strat_engine/pool/inspection.rs.

@jbaublitz
Copy link
Member Author

@mulkieran Why didn't this show up when I ran the git hooks? Is building that code not invoked in the githooks currently?

@mulkieran
Copy link
Member

@mulkieran Why didn't this show up when I ran the git hooks? Is building that code not invoked in the githooks currently?

Those are part of stratisd-tools, so they are built.

@jbaublitz
Copy link
Member Author

Oh, I understand! I thought it was a compilation error, not a testing error.

@jbaublitz jbaublitz force-pushed the token-slot-area branch 4 times, most recently from d91b01e to 67e541f Compare January 23, 2025 14:36
mulkieran
mulkieran requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proposed change will fix the errors.

src/engine/strat_engine/pool/inspection.rs Outdated Show resolved Hide resolved
@jbaublitz jbaublitz force-pushed the token-slot-area branch 2 times, most recently from 9cf530f to 05a2546 Compare January 23, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulkieran mulkieran mulkieran approved these changes

Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
2025January
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbaublitz @mulkieran