Include crypt metadata in total_physical_used #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
fix-missing-crypt-metadata
branch
5 times, most recently
from
a30f74c to
a3e57a1
Compare
mulkieran
force-pushed
the
fix-missing-crypt-metadata
branch
3 times, most recently
from
e3dead6 to
42b7a7d
Compare
Revise datatier_metadata_size so that it returns a value that includes the crypt metadata allocation. Introduce a new method for the crypt_metadata_size. Remove testing-only data_alloc_size() method, but have datatier_allocated_size() return what data_alloc_size() method returned previously. This changes the result, to not include the crypt meta allocs. This change balances out the datatier_metadata_size change. Change datatier_usable_size() to use backstore methods to calculate the same result as formerly. Change available_in_backstore to use backstore methods to calculate the same result as formerly. This change corrects problems with the D-Bus values being wrong or the D-Bus signals sending out an updated value that does not properly match the D-Bus value. It also allows to restore one test in thinpool to its original. Signed-off-by: mulhern <[email protected]>
Use the newly revised datatier_allocated_size() method in place of an expression. Add a new equality, that depends for correctness on the previous commit. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
fix-missing-crypt-metadata
branch
from
42b7a7d to
9435cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3663