Fix alignment problems #3494
Merged
Fix alignment problems #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test |
bgurney-rh
approved these changes
Nov 9, 2023
|
I want to verify that |
|
It is not. I'm going to add a round down function for the |
|
/packit test |
mulkieran
requested changes
Nov 10, 2023
bmr-cymru
approved these changes
Nov 10, 2023
Currently, data allocations from the cap device are data block aligned. Metadata allocations, however, are not. This can lead to data allocations after a metadata allocation to become unaligned as well. This has performance implications. This commit addresses this in a backwards compatiable way by using our previous metadata size calculation but rounds the total desired metadata device size up to the nearest data block size multiple. This has a few very desirable properties: 1. The metadata allocations will always be aligned to the data block size boundary. 2. The metadata allocations may appear a bit larger, but the overall growth of the step function tracks the linear growth of the original metadata space calculation function. 3. While this commit does not resolve alignment issues for pools that have already bumped into this problem, this code should theoretically cause future allocations on affected pools to be in alignment, minimizing performance impact for future allocations on affected pools.
|
/packit test |
|
@mulkieran Do you want this to go in first or the transaction revert commit? |
I think this should go in first. |
mulkieran
approved these changes
Nov 13, 2023
|
Okay sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the alignment issue was introduced in #2854. See commit message for more details.