Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm exec returns response & err #842

Merged
merged 4 commits into from
Oct 30, 2023
Merged

wasm exec returns response & err #842

merged 4 commits into from
Oct 30, 2023

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Oct 25, 2023 •
edited
Loading

Closes #823

summary

  • When dealing with CW contracts, the error is nested in the RawLog. Currently we only return an Err if there is a stdout binary issue. This PR allows the CW contract to return the err if CW ahs a non 0 resp. code.
  • Makes GetTransaction(txHash) public since it is useful

considerations

after the v7 and v8 tags for ictest, I would like to do this across the entire codebase (instead of returning (txHash, err) we return (txResp, err')

@Reecepbcups Reecepbcups mentioned this pull request Oct 25, 2023
Closed
srdtrk
srdtrk approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine XD

@Reecepbcups Reecepbcups marked this pull request as ready for review October 27, 2023 23:33
@Reecepbcups Reecepbcups requested a review from a team as a code owner October 27, 2023 23:33
@Reecepbcups Reecepbcups requested a review from agouin October 27, 2023 23:33
@Reecepbcups Reecepbcups enabled auto-merge (squash) October 28, 2023 01:50
@Reecepbcups Reecepbcups added the BACKPORT backport into all maintained branches label Oct 28, 2023
@Reecepbcups Reecepbcups merged commit 10163ee into main Oct 30, 2023
11 checks passed
@Reecepbcups Reecepbcups deleted the reece/wasm-execute-err branch October 30, 2023 17:08
mergify bot pushed a commit that referenced this pull request Oct 30, 2023
@Reecepbcups @mergify
wasm exec returns response & err (#842)
ac7fb49 
* make `GetTransaction` public

* ExecuteContract returns TxResponse

(cherry picked from commit 10163ee)

# Conflicts:
#	examples/cosmos/chain_miscellaneous_test.go
#	go.work.sum
#	local-interchain/go.mod
#	local-interchain/go.sum
@mergify mergify bot mentioned this pull request Oct 30, 2023
Merged
Reecepbcups added a commit that referenced this pull request Oct 30, 2023
@mergify @Reecepbcups
[BP: v7 <- #842] wasm exec returns response & err (#852)
f05c988 
* wasm exec returns response & err (#842)

* make `GetTransaction` public

* ExecuteContract returns TxResponse

(cherry picked from commit 10163ee)

# Conflicts:
#	examples/cosmos/chain_miscellaneous_test.go
#	go.work.sum
#	local-interchain/go.mod
#	local-interchain/go.sum

* v7-ify

---------

Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
@Reecepbcups Reecepbcups mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk srdtrk approved these changes

@boojamya boojamya boojamya approved these changes

@agouin agouin Awaiting requested review from agouin agouin is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm executions do not produce errors even if the contract returns an error
3 participants
@Reecepbcups @boojamya @srdtrk