Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: feat: add ics-20 token transfer support for Penumbra & implement example test cases #837

Closed
wants to merge 57 commits into from

Conversation

jtieri
Copy link
Contributor

@jtieri jtieri commented Oct 20, 2023

Description

This PR adds support for performing ics-20 token transfers to/from Penumbra in interchaintest.

To add this feature we had to wait for several fixes upstream in the Penumbra repo to rectify some discrepancies in their Proto files and the expected API we rely on in interchaintest. This means that we had to perform several upgrades to the Penumbra version, as well as the associated CometBFT version, before we could fully achieve ics-20 support in interchaintest.

How to test

$ go test -v -race ./examples/penumbra/penumbra_ibc_test.go

@jtieri jtieri changed the title feat: add ics_20 transfer support for penumbra & implement test cases feat: add ics20 transfer support for penumbra & implement test cases Nov 6, 2023
@jtieri jtieri changed the title feat: add ics20 transfer support for penumbra & implement test cases feat: add ics-20 token transfer support for Penumbra & implement example test cases Dec 13, 2023
@jtieri jtieri changed the title DO NOT MERGE: feat: add ics-20 token transfer support for Penumbra & implement example test cases feat: add ics-20 token transfer support for Penumbra & implement example test cases Jan 9, 2024
@jtieri jtieri changed the title feat: add ics-20 token transfer support for Penumbra & implement example test cases DNM: feat: add ics-20 token transfer support for Penumbra & implement example test cases Jan 16, 2024
@jtieri jtieri requested a review from a team as a code owner February 26, 2024 19:30
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 10:32pm

@jackzampolin
Copy link
Member

can we close this PR?

@jtieri
Copy link
Contributor Author

jtieri commented May 11, 2024

can we close this PR?

this is the long running PR to add support for pclientd and Penumbra IBC. we have been blocked on issues related to timeouts and are still waiting for the Penumbra team to have bandwidth to help dig into the issue.

we could just get this merged and deal with the timeouts bug later. i can handle the conflicts and get @Reecepbcups to review this next week?

@Reecepbcups
Copy link
Member

Reecepbcups commented May 11, 2024

Yes, happy to review when ready

@jtieri
Copy link
Contributor Author

jtieri commented Jul 3, 2024

The Penumbra team finished adding some additional fixes that were necessary to get the timeout test cases working properly. That work was completed in a separate branch that was rebased on top of the work capture here and can be found in #1157.

Closing this out in favor of that PR instead

@jtieri jtieri closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code new test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants