-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: feat: add ics-20 token transfer support for Penumbra & implement example test cases #837
Conversation
…r use of cli args
…ics_20 transfer timeout timestamp
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
can we close this PR? |
this is the long running PR to add support for we could just get this merged and deal with the timeouts bug later. i can handle the conflicts and get @Reecepbcups to review this next week? |
Yes, happy to review when ready |
The Penumbra team finished adding some additional fixes that were necessary to get the timeout test cases working properly. That work was completed in a separate branch that was rebased on top of the work capture here and can be found in #1157. Closing this out in favor of that PR instead |
Description
This PR adds support for performing ics-20 token transfers to/from Penumbra in
interchaintest
.To add this feature we had to wait for several fixes upstream in the Penumbra repo to rectify some discrepancies in their Proto files and the expected API we rely on in
interchaintest
. This means that we had to perform several upgrades to the Penumbra version, as well as the associated CometBFT version, before we could fully achieve ics-20 support ininterchaintest
.How to test
$ go test -v -race ./examples/penumbra/penumbra_ibc_test.go