fix: authz exec and coverage directory location #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node `HomeDir()` is `/var/cosmos-chain/[CHAIN_NAME]` and not `/var/cosmos-chain/[CHAIN_ID]`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The failing test in the previous run is unrelated to this PR. It also fails on the |
Reecepbcups
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Failing e2e test is related:
code_coverage_test.go:87:
Error Trace: /home/runner/work/interchaintest/interchaintest/examples/cosmos/code_coverage_test.go:87
/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1175
/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1353
/home/runner/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:1683
Error: Should NOT be empty, but was []
Test: TestCodeCoverage
Code coverage is not finding coverage files in the home dir. It was originally pulling /var/cosmos-chain/manifest-2 which is where it is actually stored (not name), but due to that being the core repo it is possible the output never actually happened for the cov files
auto-merge was automatically disabled
July 15, 2024 13:30
Head branch was pushed to by a user without write access
Reecepbcups
reviewed
Jul 15, 2024
| @@ -52,7 +52,7 @@ func TestCodeCoverage(t *testing.T) { | |||
| { | |||
| Name: "manifest", | |||
| Version: cfgA.Images[0].Version, | |||
| ChainName: cfgA.ChainID, | |||
Reecepbcups
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
HomeDir()Relates #1130 #1158
@Reecepbcups