-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for participating tunnels #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 54.65% 53.94% -0.72%
==========================================
Files 25 30 +5
Lines 3123 3711 +588
==========================================
+ Hits 1707 2002 +295
- Misses 1416 1709 +293
Continue to review full report at Codecov.
|
str4d
force-pushed
the
tunnels
branch
3 times, most recently
from
April 15, 2019 00:13
cef779d
to
f0318d8
Compare
- `to_peer` is not needed in the struct. - `flag` is now parsed and validated as the hop type.
BuildRequestRecords omit the two excess zeroes from the I2P ElGamal ciphertext, but since ElGamalAES+SessionTags requires them, we need to support both ciphertext formats.
We still get length-checking at runtime because of the internal use of GenericArray. We were already relying on runtime checks in the array_ref![] macro, so this is fine.
Each build request is spawned into its own task, which uses the blocking threadpool for encryption operations. Currently the listener accepts every request for an intermediate position, and rejects every IBGW and OBEP request.
Currently only supports intermediate hops, not IBGWs or OBEPs.
We assume that a router's RouterIdentity will never change while it is running. Its RouterInfo will change when it is republished.
The tests require creating threadpools, which will not work until xd009642/tarpaulin#190 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47.