Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Test: Add Vitest 3 support #30181

Draft
wants to merge 10 commits into
base: valentin/a11y-refactorings
Choose a base branch
from

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 3, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-30181-sha-dba7ad37. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-30181-sha-dba7ad37
Triggered by @valentinpalkovic
Repository storybookjs/storybook
Branch valentin/add-vitest-3-support
Commit dba7ad37
Datetime Fri Jan 3 11:55:37 UTC 2025 (1735905337)
Workflow run 12597305331

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30181

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 0 B -1.45 0%
initSize 131 MB 131 MB 0 B -0.84 0%
diffSize 53 MB 53 MB 0 B -0.84 0%
buildSize 7.19 MB 7.19 MB 0 B 1.73 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B -0.94 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B -0.94 0%
buildPreviewSize 3.28 MB 3.28 MB 0 B 1.77 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 21.2s 6.6s -14s -554ms -1.01 -218.3%
generateTime 21.4s 19s -2s -478ms -1.41 🔰-13%
initTime 15.2s 12.4s -2s -758ms -1.7 🔰-22.1%
buildTime 8.7s 11.8s 3.1s 3.42 🔺26.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.1s 4.4s -653ms -0.72 -14.6%
devManagerResponsive 3.9s 3.4s -558ms -0.44 -16.3%
devManagerHeaderVisible 718ms 582ms -136ms -0.33 -23.4%
devManagerIndexVisible 750ms 610ms -140ms -0.32 -23%
devStoryVisibleUncached 1.4s 1.8s 376ms -0.01 20.5%
devStoryVisible 748ms 612ms -136ms -0.35 -22.2%
devAutodocsVisible 576ms 483ms -93ms -1.05 -19.3%
devMDXVisible 740ms 566ms -174ms 0.29 -30.7%
buildManagerHeaderVisible 657ms 526ms -131ms -0.65 -24.9%
buildManagerIndexVisible 743ms 616ms -127ms -0.68 -20.6%
buildStoryVisible 629ms 519ms -110ms -0.57 -21.2%
buildAutodocsVisible 490ms 453ms -37ms -0.14 -8.2%
buildMDXVisible 546ms 402ms -144ms -0.84 -35.8%

@valentinpalkovic valentinpalkovic changed the base branch from next to valentin/a11y-refactorings January 3, 2025 11:00
@valentinpalkovic valentinpalkovic self-assigned this Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

Generated by 🚫 dangerJS against cbc7305

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/12596687166

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/12596812168

Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 61996e1.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-10 09:47:21 UTC

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/12596958152

@valentinpalkovic valentinpalkovic added bug ci:daily Run the CI jobs that normally run in the daily job. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants