Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update http put args description #117

Closed
wants to merge 1 commit into from

Conversation

vasco-santos
Copy link
Contributor

We updated this but did not change it all

@vasco-santos vasco-santos force-pushed the fix/update-http-put-args-description branch from b268fde to 5ab1eff Compare April 8, 2024 11:38
Comment on lines +175 to 176
// TODO: this should now be updated?
"address": { "await/ok": { "/": "bafy...alloc" } },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gozala this ended up changing below to use url and headers https://github.com/web3-storage/specs/blob/main/w3-blob.md#put-blob-capability-schema

I honestly liked more the previous alignment here with address, but happy to change this if you have strong preference to use url and header top level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume if so, we would like to have something along the lines of

'ucan/await': ['.out.ok.claim', acceptfx.link()],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I end up updating it here https://github.com/web3-storage/specs/pull/118/files last week but forgot to submit a PR for the review. I do not feel very strongly about it, however I find { url, headers, body } to be more obvious choice for http/put than { address, body }.

@Gozala
Copy link
Collaborator

Gozala commented Apr 8, 2024

I think this is superseded by #118 but let me know if you think it should not.

vasco-santos added a commit to storacha/w3up that referenced this pull request Apr 9, 2024
vasco-santos added a commit to storacha/w3up that referenced this pull request Apr 11, 2024
vasco-santos added a commit to storacha/w3up that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants