-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change remote write behaviour in the case of additional external endpoints #90
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Philip Gough <[email protected]>
This changes refactors the Proxy remote wrtie handler to do as much work outside of the handler as possible. There is a major change in behaviour. The extra endpoints are now written to async in the background of the main request. Extra endpoints will be written to with best effort and logged. The response code from the thanos backend will be returned to the client. This will cause the client to retry on specific errors and will have a knock on effect of a successfully written request prior being attempted once again to the extra remote write endpoints.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@philipgough: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
expectLogs map[string]parsedLog | ||
}{ | ||
{ | ||
name: "test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add more cases here
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Related to https://issues.redhat.com/browse/ACM-6685