Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual sync of upstream PRs: #188, #185 #582

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Feb 19, 2024

Closes #581

The conflict was in the GitHub workflow.

mprahl and others added 6 commits February 19, 2024 15:04
This also clarifies the status code that should be returned by
introducing a new ErrForbidden error.

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 6820095)
Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 2fa0a9e)
ref: https://issues.redhat.com/browse/ACM-9975

Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit bc57446)
Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit d36fb1d)
Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit d0ec507)
@mprahl
Copy link
Contributor Author

mprahl commented Feb 19, 2024

/override "Red Hat Konflux / governance-policy-propagator-fm3n-on-pull-request"

Copy link

openshift-ci bot commented Feb 19, 2024

@mprahl: Overrode contexts on behalf of mprahl: Red Hat Konflux / governance-policy-propagator-fm3n-on-pull-request

In response to this:

/override "Red Hat Konflux / governance-policy-propagator-fm3n-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhaiducek
Copy link
Contributor

/override "Red Hat Konflux / governance-policy-propagator-fm3n-on-pull-request"

Don't override it--I neglected to update Dockerfile.rhtap to 1.21:

FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_1.20 AS builder

You can bump it to rhel_9_1.21.

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Feb 19, 2024
@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
@openshift-ci openshift-ci bot removed the lgtm label Feb 19, 2024
@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
Signed-off-by: mprahl <[email protected]>
(cherry picked from commit eaecd20)
@openshift-ci openshift-ci bot removed the lgtm label Feb 19, 2024
@mprahl mprahl requested a review from dhaiducek February 19, 2024 21:00
Copy link

sonarqubecloud bot commented Feb 19, 2024

Copy link

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek,mprahl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl mprahl merged commit 93ded0e into stolostron:main Feb 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #188, #185
3 participants