[release-2.9] Manual cherry-pick: Fix status update with faulty PlacementBinding #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dale Haiducek <[email protected]> (cherry picked from commit 78839d2)
yiraeChristineKim
previously approved these changes
Feb 15, 2024
With a PlacementBinding containing an invalid placementRef, the propagator was returning an error and endlessly re-reconciling. This occurs even if the PlacementBinding was not bound to the Policy. ref: https://issues.redhat.com/browse/ACM-9930 Signed-off-by: Dale Haiducek <[email protected]> (cherry picked from commit 41176f2) Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
566-cherry-pick-2.9
branch
from
8e9199e to
2483eaf
Compare
|
gparvin
approved these changes
Feb 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, gparvin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d60275a
into
stolostron:release-2.9
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick from:
With a PlacementBinding containing an invalid placementRef, the propagator was returning an error and endlessly re-reconciling. This occurs even if the PlacementBinding was not bound to the Policy.
Also swaps the namespace and name in the message because it was non-standard.
ref: https://issues.redhat.com/browse/ACM-9930