Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-propagator: #169, #170, #168, #172 #551

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

dhaiducek and others added 8 commits February 6, 2024 15:10
Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit 2b048de)
Calling row.Err() is not required since row.Scan() returns the error if
it's present.

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 222f264)
Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 025b61b)
Signed-off-by: mprahl <[email protected]>
(cherry picked from commit e93afec)
- disable webhook when run locally
- `tee` E2E logs

Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit ae8224c)
ref: https://issues.redhat.com/browse/ACM-9461
Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit c3c38e1)
Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit 0de26d2)
Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Contributor

mprahl commented Feb 6, 2024

/override "Test Coverage Verification"

Copy link

openshift-ci bot commented Feb 6, 2024

@mprahl: Overrode contexts on behalf of mprahl: Test Coverage Verification

In response to this:

/override "Test Coverage Verification"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl
Copy link
Contributor

mprahl commented Feb 6, 2024

I'll force merge this and rely on Magic Mirror to sync the PR to fix the new gosec violation:
open-cluster-management-io/governance-policy-propagator#173

@mprahl mprahl merged commit 036cc67 into main Feb 6, 2024
16 of 18 checks passed
@mprahl mprahl deleted the magic-mirror-main-1707232195152 branch February 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants