Manual sync of the upstream PR: #165 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the compliance events API is enabled, the replicated policies will contain the annotation policy.open-cluster-management.io/parent-policy-compliance-db-id and each of its policy-templates entries will have the policy.open-cluster-management.io/policy-compliance-db-id annotation. As part of this, resilience to database connection losses and changes was added. This is done by monitoring the database connection. If the database connection is down, the replicated policy controller will queue up reconcile requests to add the database specific annotations if the answer isn't already cached. Once the database connection is restored, the queued up reconciles will be triggered. Note that now everytime a database connection changes, a database migration is run. This is an idempotent action and it's to catch the case where the database server has been swapped out or restored to an older backup which may not have the latest database schema. Relates: https://issues.redhat.com/browse/ACM-6889 Signed-off-by: mprahl <[email protected]> (cherry picked from commit 784bd89)
Signed-off-by: mprahl <[email protected]> (cherry picked from commit b9ce393)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #548