Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip SonarCloud run on push #537

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dhaiducek
Copy link
Contributor

@dhaiducek
Copy link
Contributor Author

Oops. This needs to be upstream.

@dhaiducek dhaiducek closed this Jan 17, 2024
@dhaiducek dhaiducek deleted the re-enable-sonar branch January 17, 2024 14:23
@dhaiducek dhaiducek restored the re-enable-sonar branch January 17, 2024 14:26
@dhaiducek
Copy link
Contributor Author

...actually, it does make sense to not run it upstream since there's no Sonar there. Re-opening.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7a4244c into stolostron:main Jan 17, 2024
18 checks passed
@dhaiducek dhaiducek deleted the re-enable-sonar branch January 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants