🤖 Sync from open-cluster-management-io/governance-policy-propagator: #145 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
It was previously copying the entire root policy status when building the replicated policy which can get quite large when a policy applies to thousands of clusters. Now, only the metadata and spec are copied. In a test environment with 3000 clusters that have 10 policies apply to it, it saved several GBs of memory allocations after the initial reconciles completed. Signed-off-by: mprahl <[email protected]> (cherry picked from commit fb7d252)
Since policy objects are often deep copied, we can save on memory usage and allocations by not caching these large unused fields. Signed-off-by: mprahl <[email protected]> (cherry picked from commit c3dc396)
This will save on memory utilization in the cache and every time IsInClusterNamespace is called, it will not deep copy the entire object. Signed-off-by: mprahl <[email protected]> (cherry picked from commit a49cfc8)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs: