Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-propagator: #144 #492

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

To reduce the number of unnecessary reconciles on replicated policies,
when a PlacementBinding is updated, only the added or removed policies
are reconciled. However, this meant that when other fields are updated
in a PlacementBinding, the affected policies were not being updated
accordingly. Now, when there are other changes, all possibly affected
replicated policies will be reconciled.

Refs:
 - https://issues.redhat.com/browse/ACM-8515

Signed-off-by: Justin Kulikauskas <[email protected]>
(cherry picked from commit a06836b)
Copy link

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Contributor

mprahl commented Nov 7, 2023

/cherry-pick release-2.9

@openshift-cherrypick-robot

@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JustinKuli
Copy link
Contributor

/cherry-pick release-2.9

@openshift-cherrypick-robot

@JustinKuli: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit 4718c34 into main Nov 7, 2023
15 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1699373095931 branch November 7, 2023 16:25
@openshift-cherrypick-robot

@JustinKuli: new pull request created: #494

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants