Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-propagator: #142 #478

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

Currently, when the remediationAction field is unset in both the root
policy and configuration policy in its policy template, the violation
is generated as an event by the config-policy controller in the
managed cluster.

This PR addresses the issue by updating the validating webhook so that
the violation can be caught on policy creation and updates on the hub.

ref: https://issues.redhat.com/browse/ACM-7551
Signed-off-by: Jason Zhang <[email protected]>
(cherry picked from commit 5adbb99)
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@magic-mirror-bot magic-mirror-bot bot merged commit 135c7fe into main Oct 25, 2023
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1698261915656 branch October 25, 2023 19:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant