Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Sync of #137 #464

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Manual Sync of #137 #464

merged 1 commit into from
Oct 17, 2023

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Oct 17, 2023

Closes #463

The conflict was in go.sum

This leverages the new caching functionality in go-template-utils so
that API queries are not duplicated.

As a side-effect, this should cause less reconciles because when
starting a watch due to a hub template, it does not cause an initial
reconcile merely from the watch being created.

Relates:
https://issues.redhat.com/browse/ACM-7402
https://issues.redhat.com/browse/ACM-7398

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit df22cc2)
@mprahl
Copy link
Contributor Author

mprahl commented Oct 17, 2023

/cherry-pick release-2.9

@openshift-cherrypick-robot

@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.8% 86.8% Coverage
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot merged commit 3eb01c9 into stolostron:main Oct 17, 2023
11 checks passed
@openshift-cherrypick-robot

@mprahl: #464 failed to apply on top of branch "release-2.9":

Applying: Cache hub template queries
Using index info to reconstruct a base tree...
M	controllers/propagator/encryption.go
M	controllers/propagator/encryption_test.go
M	controllers/propagator/propagation.go
A	controllers/propagator/replicatedpolicy_controller.go
A	controllers/propagator/replicatedpolicy_setup.go
M	go.mod
M	go.sum
M	main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
CONFLICT (content): Merge conflict in main.go
Auto-merging go.sum
Auto-merging go.mod
CONFLICT (modify/delete): controllers/propagator/replicatedpolicy_setup.go deleted in HEAD and modified in Cache hub template queries. Version Cache hub template queries of controllers/propagator/replicatedpolicy_setup.go left in tree.
CONFLICT (modify/delete): controllers/propagator/replicatedpolicy_controller.go deleted in HEAD and modified in Cache hub template queries. Version Cache hub template queries of controllers/propagator/replicatedpolicy_controller.go left in tree.
Auto-merging controllers/propagator/propagation.go
CONFLICT (content): Merge conflict in controllers/propagator/propagation.go
Auto-merging controllers/propagator/encryption_test.go
Auto-merging controllers/propagator/encryption.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cache hub template queries
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl
Copy link
Contributor Author

mprahl commented Oct 17, 2023

/cherry-pick release-2.9

@openshift-cherrypick-robot

@mprahl: new pull request created: #465

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #137
3 participants