-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Sync of #137 #464
Manual Sync of #137 #464
Conversation
This leverages the new caching functionality in go-template-utils so that API queries are not duplicated. As a side-effect, this should cause less reconciles because when starting a watch due to a hub template, it does not cause an initial reconcile merely from the watch being created. Relates: https://issues.redhat.com/browse/ACM-7402 https://issues.redhat.com/browse/ACM-7398 Signed-off-by: mprahl <[email protected]> (cherry picked from commit df22cc2)
/cherry-pick release-2.9 |
@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
@mprahl: #464 failed to apply on top of branch "release-2.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-2.9 |
@mprahl: new pull request created: #465 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes #463
The conflict was in go.sum