Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint error in /methods and remove usage of internal error package #285

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Fix lint error in /methods and remove usage of internal error package #285

merged 9 commits into from
Sep 9, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Sep 5, 2024 •
edited
Loading

This diff does following:

  • Remove usage of internal error
  • Fix lint errors in /methods

Fixes: -- #266

@psheth9 psheth9 marked this pull request as ready for review September 6, 2024 16:17
Shaptic
Shaptic reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla notes, I think tests will fail cuz of len() but otherwise nice work!!

cmd/soroban-rpc/internal/methods/get_transactions_test.go Outdated Show resolved Hide resolved
cmd/soroban-rpc/internal/methods/simulate_transaction.go Show resolved Hide resolved
@psheth9 psheth9 changed the title Remove usage of internal error package Fix lint error in /methods and remove usage of internal error package Sep 6, 2024
@psheth9 psheth9 requested review from aditya1702 and a team September 6, 2024 23:32
@psheth9 psheth9 merged commit 4203a0b into main Sep 9, 2024
19 checks passed
@psheth9 psheth9 deleted the remove-internal-error-package branch September 9, 2024 22:02
@psheth9 psheth9 self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

@aditya1702 aditya1702 Awaiting requested review from aditya1702

Assignees

@psheth9 psheth9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psheth9 @Shaptic