GetDKAN#4159: Increase textfields maxlength - better place for inject…

…ing maxlength
stefan-korn · Apr 25, 2024 · 576ea1e · 576ea1e
1 parent bd4c018
commit 576ea1e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/json_form_widget/src/StringHelper.php b/modules/json_form_widget/src/StringHelper.php
@@ -65,9 +65,6 @@ public function handleStringElement($definition, $data, $object_schema = FALSE)
     $element = [
       '#type' => $this->getElementType($property),
     ];
-    if ($element['#type'] === 'textfield') {
-      $element['#maxlength'] = 256;
-    }
     $element['#title'] = $property->title ?? '';
     $element['#description'] = $property->description ?? '';
     $element['#description_display'] = 'before';

diff --git a/modules/json_form_widget/src/WidgetRouter.php b/modules/json_form_widget/src/WidgetRouter.php
@@ -80,6 +80,9 @@ public function getConfiguredWidget($spec, array $element) {
       $method_name = $widgets[$spec->widget];
       $element = $this->$method_name($spec, $element);
     }
+    if ($element['#type'] === 'textfield' && empty($element['#maxlength'])) {
+      $element['#maxlength'] = 256;
+    }
     return $element;
   }