Added panic print in executable run.

[orizi]

Stack:

• Added panic print in executable run. #7131 ⬅
• Added failure for bad types in building an executable. #7129

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/bin/cairo-execute/src/main.rs line 248 at r1 (raw file):

        runner.vm.write_output(&mut output_buffer)?;
        print!("{output_buffer}");
        if let [start_marker, end_marker] = &hint_processor.markers[..] {

This is going to break if someone else uses markers.
Do you want the markers to be that generic?
if so maybe take the last two markers?

Suggestion:

[.., start_marker, end_marker] = &hint_processor.markers[..]

[orizi]

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/bin/cairo-execute/src/main.rs line 248 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

This is going to break if someone else uses markers.
Do you want the markers to be that generic?
if so maybe take the last two markers?

i like it - Done

[ilyalesokhin-starkware]

crates/cairo-lang-casm/src/hints/mod.rs line 357 at r1 (raw file):

    #[cfg_attr(feature = "parity-scale-codec", codec(index = 1))]
    WriteRunParam { index: ResOperand, dst: CellRef },
    /// Writes a marker into the VM. Useful for debugging.

Suggestion:

 /// stores a marker in the HintProcessor. Useful for debugging.

[ilyalesokhin-starkware]

Reviewed 5 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 6 of 9 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 425 at r1 (raw file):

        let ret = CellExpression::Deref(deref!([ap - unprocessed_return_size]));
        unprocessed_return_size -= 1;
        ret

ret is a bit confusing.
consider deref or res

Suggestion:

        let deref = CellExpression::Deref(deref!([ap - unprocessed_return_size]));
        unprocessed_return_size -= 1;
        deref

[orizi]

Reviewable status: 5 of 9 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-runnable-utils/src/builder.rs line 425 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

ret is a bit confusing.
consider deref or res

Done.

---

crates/cairo-lang-casm/src/hints/mod.rs line 357 at r1 (raw file):

    #[cfg_attr(feature = "parity-scale-codec", codec(index = 1))]
    WriteRunParam { index: ResOperand, dst: CellRef },
    /// Writes a marker into the VM. Useful for debugging.

Done.

[ilyalesokhin-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: 7 of 9 files reviewed, all discussions resolved