Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made associated items not replaced if they aren't of the Self trait. #7027

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 8, 2025

No description provided.

@orizi orizi requested a review from TomerStarkware January 8, 2025 14:59
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/dont-affect-associated-items-between-types branch from e950a37 to 8681d08 Compare January 8, 2025 14:59
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jan 8, 2025
@orizi orizi linked an issue Jan 8, 2025 that may be closed by this pull request
Merged via the queue into main with commit 61c56af Jan 8, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: compiler panics when defining default trait impl
3 participants