Simplify Parallel Executor #2031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNuevoDia
commented
Jan 9, 2025
Comment on lines
-71
to
-106
| def test_multi_thread_evaluate_call_cancelled(monkeypatch): | ||
| # slow LM that sleeps for 1 second before returning the answer | ||
| class SlowLM(DummyLM): | ||
| def __call__(self, *args, **kwargs): | ||
| import time | ||
|
|
||
| time.sleep(1) | ||
| return super().__call__(*args, **kwargs) | ||
|
|
||
| dspy.settings.configure(lm=SlowLM({"What is 1+1?": {"answer": "2"}, "What is 2+2?": {"answer": "4"}})) | ||
|
|
||
| devset = [new_example("What is 1+1?", "2"), new_example("What is 2+2?", "4")] | ||
| program = Predict("question -> answer") | ||
| assert program(question="What is 1+1?").answer == "2" | ||
|
|
||
| # spawn a thread that will sleep for .1 seconds then send a KeyboardInterrupt | ||
| def sleep_then_interrupt(): | ||
| import time | ||
|
|
||
| time.sleep(0.1) | ||
| import os | ||
|
|
||
| os.kill(os.getpid(), signal.SIGINT) | ||
|
|
||
| input_thread = threading.Thread(target=sleep_then_interrupt) | ||
| input_thread.start() | ||
|
|
||
| with pytest.raises(KeyboardInterrupt): | ||
| ev = Evaluate( | ||
| devset=devset, | ||
| metric=answer_exact_match, | ||
| display_progress=False, | ||
| num_threads=2, | ||
| ) | ||
| score = ev(program) | ||
| assert score == 100.0 |
There was a problem hiding this comment.
This effectively got moved to tests/utils/test_parallelizer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.