New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small style fix for json_adapter #1984

Merged

chenmoneygithub merged 1 commit into stanfordnlp:main from chenmoneygithub:random-fix-13

Dec 24, 2024

Collaborator

chenmoneygithub commented Dec 24, 2024

A few small fixes:

Use absolute import instead of relative imports.
Consistently use 4-space indentations.
_logger should be replaced by logger. This is weird at first glance because _logger seems to be a private member, however it is a standard approach to use logger. https://realpython.com/python-logging/#instantiating-your-logger


          small style fix for json_adapter

16a0a89

chenmoneygithub merged commit c6916c3 into stanfordnlp:main

4 checks passed

chenmoneygithub deleted the random-fix-13 branch

December 27, 2024 22:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet