Fix the Image class's from_url method error #1903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhat
reviewed
Dec 8, 2024
pyproject.toml
Outdated
| @@ -45,6 +45,7 @@ dependencies = [ | |||
| "anyio", | |||
| "asyncer==0.0.8", | |||
| "cachetools", | |||
| "transformers>=4.47.0", | |||
There was a problem hiding this comment.
Thanks @DigitalPig for the PR!! Why add transformers?
There was a problem hiding this comment.
ImportError while importing test module '/home/digitalpig/Codes/dspy/tests/modules/test_hf_model.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/home/linuxbrew/.linuxbrew/opt/[email protected]/lib/python3.12/importlib/__init__.py:90: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/modules/test_hf_model.py:2: in <module>
from transformers import AutoModelForSeq2SeqLM
E ModuleNotFoundError: No module named 'transformers'
Maybe the best place to put is the [dev] section?
|
@okhat let me know if there is anything else you see potential improvements before it can be merged? Thanks and Happy Holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the #1902 .
Also, I found there are some dependencies missing when running the test from a fresh virtual environment so add them in the pyproject.toml file. Please let me know if that is the best place to hold them? Thank you!