Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the 'vars' argument to draws_pd to filter new columns #718

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #717. This makes it so the columns added in #677 (e.g. chain__) can be filtered by using the vars argument, the same way e.g. lp__ can.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
Copy link
Member Author

@mitzimorris mind reviewing?

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for cleaning this up!

@WardBrian WardBrian merged commit 46f8608 into develop Jan 22, 2024
16 checks passed
@WardBrian WardBrian deleted the fix/717-draws_pd-diagnostic-filtering branch January 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draws_pd to explicitly control inclusion/exclusion of diagnostic/chain data columns
2 participants