Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for arbitrary volumes #544

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Allow for arbitrary volumes #544

merged 5 commits into from
Dec 13, 2023

Conversation

gilles-gosuin
Copy link
Contributor

@gilles-gosuin gilles-gosuin commented Oct 11, 2023

The Helm chart currently allows for disabling service account token automounting, yet reloader needs API access as far as I can tell; as a result, disabling automounting makes reloader unusable.

Making manual token mounting possible solves that issue.

(We have paranoid security policies mandating that automounting be turned off)

@github-actions
Copy link

@gilles-gosuin Image is available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-54f2fdb7

Copy link

github-actions bot commented Nov 1, 2023

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-539186f2\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-UBI-539186f2

@karl-johan-grahn
Copy link
Contributor

@gilles-gosuin thank you for your contribution, can you just elaborate on the use case by adding it as a description of the PR, thank you

Copy link

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-357bc356\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-UBI-357bc356

Copy link

github-actions bot commented Dec 6, 2023

@karl-johan-grahn Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-45fb3551\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-UBI-45fb3551

Copy link

@MuneebAijaz Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-b0cd3358\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-544-UBI-b0cd3358

@MuneebAijaz MuneebAijaz merged commit 3f0c824 into stakater:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants