refactor: streamline propagate function and remove nextSub intermedia…

…te variable
stackblitz · Jan 7, 2025 · e4a4ece · e4a4ece
1 parent d605271
commit e4a4ece
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/src/system.ts b/src/system.ts
@@ -123,7 +123,6 @@ export function propagate(subs: Link): void {
 	let targetFlag = SubscriberFlags.Dirty;
 	let link = subs;
 	let stack = 0;
-	let nextSub: Link | undefined;
 
 	top: do {
 		const sub = link.sub;
@@ -181,16 +180,17 @@ export function propagate(subs: Link): void {
 			sub.flags = subFlags | targetFlag;
 		}
 
-		if ((nextSub = subs.nextSub) === undefined) {
+		if ((link = subs.nextSub!) === undefined) {
 			if (stack) {
 				let dep = subs.dep;
 				do {
 					--stack;
 					const depSubs = dep.subs!;
 					const prevLink = depSubs.prevSub!;
 					depSubs.prevSub = undefined;
-					link = subs = prevLink.nextSub!;
-					if (subs !== undefined) {
+					link = prevLink.nextSub!;
+					if (link !== undefined) {
+						subs = link;
 						targetFlag = stack
 							? SubscriberFlags.ToCheckDirty
 							: SubscriberFlags.Dirty;
@@ -201,12 +201,10 @@ export function propagate(subs: Link): void {
 			}
 			break;
 		}
-		if (link !== subs) {
-			targetFlag = stack
-				? SubscriberFlags.ToCheckDirty
-				: SubscriberFlags.Dirty;
-		}
-		link = subs = nextSub;
+		subs = link;
+		targetFlag = stack
+			? SubscriberFlags.ToCheckDirty
+			: SubscriberFlags.Dirty;
 	} while (true);
 
 	if (!batchDepth) {