You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @yedidyar-ni , thanks for this, but the llm provider code is refactored and made more organized, will you be able to adapt your changes according to the latest code
@thecodacus
I think the PR you approved a few days ago: #974
covers everything this offers except for the more granular use of the AWS credentials
I think its safe to close this one at this point and @yedidyar-ni could modify the handling of the Keys in a new PR if he wants or this can sit on our teams to-do list as well until some one takes care of it.
But given this PR now has a lot of conflicts with main I don't think this tiny change is worth pursuing in this PR further.
Unless you see any other reason to keep this open I will cycle through and close by the end of weekend.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.