Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATACMNS-1509 - Ignore override properties with non-assignable types when creating PersistentEntity. #390

Closed
wants to merge 5 commits into from
Closed

DATACMNS-1509 - Ignore override properties with non-assignable types when creating PersistentEntity. #390

wants to merge 5 commits into from

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Apr 8, 2019 •
edited
Loading

@christophstrobl christophstrobl mentioned this pull request Apr 8, 2019
Draft
@mp911de mp911de self-assigned this Feb 8, 2021
@gregturn gregturn changed the base branch from master to main April 15, 2021 17:16
christophstrobl and others added 4 commits April 19, 2021 09:25
@christophstrobl @mp911de
DATACMNS-1509 - Prepare issue branch.
3ab0b7d
@christophstrobl @mp911de
DATACMNS-1509 - Ignore Kotlin override properties when creating Persi…
74ae72e 
…stentEntity.
@mp911de
Limit BeanWrapper's KotlinCopyUtil to Kotlin Data classes.
acdc58c 
Previously, we tried to invoke the copy(…) method on all Kotlin classes whereas the copy(…) method is only specific to Kotlin data classes.
@mp911de
Skip shadowed properties that are not assignable to their shadowing t…
0035e43 
…ype.
@mp911de mp911de force-pushed the issue/DATACMNS-1509 branch from 766bc65 to 0035e43 Compare April 19, 2021 08:33
@mp911de mp911de changed the title DATACMNS-1509 - Ignore Kotlin override properties when creating PersistentEntity. DATACMNS-1509 - Ignore override properties with non-assignable types when creating PersistentEntity. Apr 20, 2021
@mp911de
Polishing.
4a79e26 
Extend tests. Document property overrides.
@mp911de mp911de force-pushed the issue/DATACMNS-1509 branch from 99ae12f to 4a79e26 Compare April 20, 2021 14:50
mp911de pushed a commit that referenced this pull request Apr 21, 2021
@christophstrobl @mp911de
Ignore override properties when creating PersistentEntity.
85578b5 
Original pull request: #390.
Closes #1911.
mp911de added a commit that referenced this pull request Apr 21, 2021
@mp911de
Polishing.
40222d6 
Skip shadowed properties that are not assignable to their shadowing type.

Extend tests. Document property overrides.

Original pull request: #390.
See #1911.
mp911de added a commit that referenced this pull request Apr 21, 2021
@mp911de
Limit BeanWrapper's KotlinCopyUtil to Kotlin Data classes.
c94fe6d 
Previously, we tried to invoke the copy(…) method on all Kotlin classes whereas the copy(…) method is only specific to Kotlin data classes.

Original pull request: #390.
Closes #2358.
mp911de added a commit that referenced this pull request Apr 21, 2021
@mp911de
Limit BeanWrapper's KotlinCopyUtil to Kotlin Data classes.
786ebec 
Previously, we tried to invoke the copy(…) method on all Kotlin classes whereas the copy(…) method is only specific to Kotlin data classes.

Original pull request: #390.
Closes #2358.
mp911de added a commit that referenced this pull request Apr 21, 2021
@mp911de
Limit BeanWrapper's KotlinCopyUtil to Kotlin Data classes.
3940400 
Previously, we tried to invoke the copy(…) method on all Kotlin classes whereas the copy(…) method is only specific to Kotlin data classes.

Original pull request: #390.
Closes #2358.
@mp911de mp911de marked this pull request as ready for review April 21, 2021 07:31
@mp911de mp911de added this to the 2.6 M1 (2021.1.0) milestone Apr 21, 2021
@mp911de
Copy link
Member

mp911de commented Apr 21, 2021

That's merged and polished now.

@mp911de mp911de closed this Apr 21, 2021
@mp911de mp911de deleted the issue/DATACMNS-1509 branch April 21, 2021 07:32
@schauder schauder mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

@odrotbohm odrotbohm Awaiting requested review from odrotbohm

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
None yet
Projects
None yet
Milestone
2.6 M1 (2021.1.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@christophstrobl @mp911de