Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spring-batch-notion #147

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

scordio
Copy link
Collaborator

@scordio scordio commented Oct 15, 2024

See scordio/spring-batch-notion#53.

Open points:

  • Align license header to spring-batch-extensions standard
  • Update badge links in spring-batch-notion/README.md

@scordio
Copy link
Collaborator Author

scordio commented Oct 15, 2024

The CI fails with compilation errors, I'll look into them.

@scordio scordio force-pushed the spring-batch-notion branch 4 times, most recently from fcad394 to d2e26ae Compare October 15, 2024 12:57
@scordio
Copy link
Collaborator Author

scordio commented Oct 15, 2024

The CI fails with compilation errors, I'll look into them.

It looks good now – something was wrong with spring-cloud-contract-wiremock.

Anyway, I had in mind to replace it with wiremock-spring-boot, so I grabbed the opportunity.

@scordio scordio force-pushed the spring-batch-notion branch 3 times, most recently from 3d798f7 to 998fec6 Compare October 15, 2024 15:10
README.md Show resolved Hide resolved
@scordio scordio marked this pull request as ready for review October 15, 2024 15:51
spring-batch-notion/pom.xml Outdated Show resolved Hide resolved
@fmbenhassine
Copy link
Contributor

Thank you for the PR, @scordio !

Apart from the JReleaser plugin removal , it looks good to me. Please add your name as author in all files (ie add @author tag in the javadoc of all classes, tests included) as well as in the Staying in touch section of the main readme file. After that, it will be good to merge. Many thanks upfront!

@scordio
Copy link
Collaborator Author

scordio commented Oct 16, 2024

Please add your name as author in all files (ie add @author tag in the javadoc of all classes, tests included) as well as in the Staying in touch section of the main readme file.

I think everything should be done now.

Could you please allow the workflow to be executed to ensure everything works correctly in this repo and not only in my fork?

@fmbenhassine
Copy link
Contributor

Could you please allow the workflow to be executed to ensure everything works correctly in this repo and not only in my fork?

Done

@scordio
Copy link
Collaborator Author

scordio commented Oct 24, 2024

@fmbenhassine POM and CI simplified, Spring Boot version updated to the latest

@scordio scordio force-pushed the spring-batch-notion branch from cf513d3 to 3513c89 Compare October 25, 2024 14:51
@scordio scordio force-pushed the spring-batch-notion branch from 3513c89 to 65b2b52 Compare October 25, 2024 14:52
@scordio
Copy link
Collaborator Author

scordio commented Oct 25, 2024

When releasing, would it be possible to do it with Java 21 or greater?

The Javadoc website would get goodies like the search URL (see the current one here).

@fmbenhassine
Copy link
Contributor

When releasing, would it be possible to do it with Java 21 or greater?

Sure! Please just remind me about that in the ticket you will create to request a release. Thank you.

@fmbenhassine fmbenhassine merged commit 65b2b52 into spring-projects:main Oct 28, 2024
6 checks passed
@fmbenhassine
Copy link
Contributor

LGTM now 👍 Thank you for all these updates! Rebased and merged.

@scordio
Copy link
Collaborator Author

scordio commented Oct 28, 2024

Thanks a lot!

@scordio scordio deleted the spring-batch-notion branch October 28, 2024 14:31
@scordio scordio mentioned this pull request Nov 8, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants