-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RoutesEndpoint.java #3580
base: main
Are you sure you want to change the base?
Conversation
bug fixed
@ZengYueWei Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@ZengYueWei Thank you for signing the Contributor License Agreement! |
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
============================================
- Coverage 65% 64.94% -0.06%
+ Complexity 1505 1503 -2
============================================
Files 190 190
Lines 7272 7272
Branches 870 870
============================================
- Hits 4727 4723 -4
- Misses 2232 2235 +3
- Partials 313 314 +1
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
============================================
- Coverage 65% 64.94% -0.06%
+ Complexity 1505 1503 -2
============================================
Files 190 190
Lines 7272 7272
Branches 870 870
============================================
- Hits 4727 4723 -4
- Misses 2232 2235 +3
- Partials 313 314 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
============================================
- Coverage 65% 64.94% -0.06%
+ Complexity 1505 1503 -2
============================================
Files 190 190
Lines 7272 7272
Branches 870 870
============================================
- Hits 4727 4723 -4
- Misses 2232 2235 +3
- Partials 313 314 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
============================================
- Coverage 65% 64.94% -0.06%
+ Complexity 1505 1503 -2
============================================
Files 190 190
Lines 7272 7272
Branches 870 870
============================================
- Hits 4727 4723 -4
- Misses 2232 2235 +3
- Partials 313 314 +1
Continue to review full report at Codecov.
|
Can you include a test? |
CompositeRouteLocator will sort the routeLocator by their order , so that the higher priority routeLocator will be check first.
But when we checked the route infos (by getting /actuator/routes),the route infos are different from the result we request.
It turns out that the route infos are returned by map. Because of that, if they are same route infos offering by different routeLocator, the lower priority will rewrite the higher one route info. But when we send the request, the higher one will perform.
So, I think it's something we can change to reduce ambiguity by returing same route infos as we request.