Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate netty response in NettyWriteResponseFilter #3391

Closed
wants to merge 2 commits into from

Conversation

giiiiiithub
Copy link

Make it more convenient for other filters to modify the body

@pivotal-cla
Copy link

@giiiiiithub Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@giiiiiithub Thank you for signing the Contributor License Agreement!

@giiiiiithub giiiiiithub marked this pull request as draft June 6, 2024 02:05
@giiiiiithub giiiiiithub marked this pull request as ready for review June 6, 2024 02:05
@spencergibb
Copy link
Member

I don't think I want to do this and automatically put the whole body in memory if users don't want it. CacheRequestBodyGatewayFilterFactory is the signal for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants