-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grpc status headers #2973
base: main
Are you sure you want to change the base?
Fix grpc status headers #2973
Conversation
@FliegenKLATSCH Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@FliegenKLATSCH Thank you for signing the Contributor License Agreement! |
Can you add a test? @abelsromero @Albertoimpl can you review |
@spencergibb Any hints on how I could set trailing headers for a test case? Doesn't seem to be easy :/ |
I don't. Let's wait for my co-workers tagged above to respond |
Thanks for the ping @spencergibb, and thanks a lot @FliegenKLATSCH for the contribution and for wanting to improve our tests around it. For headers, it should be something like this: https://github.com/grpc/grpc-java/blob/master/examples/src/main/java/io/grpc/examples/header/HeaderServerInterceptor.java For trailers what you see in the |
Thank you! Ping for review @Albertoimpl @abelsromero |
These assertions should cover the case, thanks @FliegenKLATSCH! |
Fixes #2961
Headers are only set, if they are received.
In case the status comes with the first header and is an error
response.setComplete()
is called to setendStream=true
and prevent an empty DATA frame being sent. This would lead toReceived unexpected EOS on DATA frame from server
errors otherwise on the grpc client side.