Polishing KeyValueConverter

spring-cloud · Mar 12, 2024 · df81812 · df81812
1 parent 7f1048a
commit df81812
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/...way-server/src/main/java/org/springframework/cloud/gateway/support/KeyValueConverter.java b/...way-server/src/main/java/org/springframework/cloud/gateway/support/KeyValueConverter.java
@@ -27,19 +27,19 @@
 @Deprecated
 public class KeyValueConverter implements Converter<String, KeyValue> {
 
-	private static final String INVALID_CONFIGURATION_MESSAGE = "Invalid configuration, expected format is: 'key:value'";
+	private static final String INVALID_CONFIGURATION_MESSAGE = "Invalid configuration, expected format is: 'key:value', received: ";
 
 	@Override
 	public KeyValue convert(String source) throws IllegalArgumentException {
 		try {
 			String[] split = source.split(":");
-			if (source.contains(":") && StringUtils.hasText(split[0])) {
+			if (split.length == 2) {
 				return new KeyValue(split[0], split.length == 1 ? "" : split[1]);
 			}
-			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE);
+			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE + source);
 		}
 		catch (ArrayIndexOutOfBoundsException e) {
-			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE);
+			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE + source);
 		}
 	}
 

diff --git a/...ver/src/main/java/org/springframework/cloud/gateway/support/config/KeyValueConverter.java b/...ver/src/main/java/org/springframework/cloud/gateway/support/config/KeyValueConverter.java
@@ -24,19 +24,19 @@
  */
 public class KeyValueConverter implements Converter<String, KeyValue> {
 
-	private static final String INVALID_CONFIGURATION_MESSAGE = "Invalid configuration, expected format is: 'key:value'";
+	private static final String INVALID_CONFIGURATION_MESSAGE = "Invalid configuration, expected format is: 'key:value', received: ";
 
 	@Override
 	public KeyValue convert(String source) throws IllegalArgumentException {
 		try {
 			String[] split = source.split(":");
-			if (source.contains(":") && StringUtils.hasText(split[0])) {
+			if (split.length == 2) {
 				return new KeyValue(split[0], split.length == 1 ? "" : split[1]);
 			}
-			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE);
+			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE + source);
 		}
 		catch (ArrayIndexOutOfBoundsException e) {
-			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE);
+			throw new IllegalArgumentException(INVALID_CONFIGURATION_MESSAGE + source);
 		}
 	}
 

diff --git a/...teway-server/src/test/resources/application-request-headers-if-not-present-web-filter.yml b/...teway-server/src/test/resources/application-request-headers-if-not-present-web-filter.yml
@@ -14,4 +14,4 @@ spring:
           - Path=/multivalueheaders
         filters:
           - AddRequestHeadersIfNotPresent=X-Request-Example:ValueA,X-Request-Second-Example:ValueC
-          - AddRequestHeadersIfNotPresent=X-Request-Example:ValueB,X-Request-Second-Example:ValueD
+          - AddRequestHeadersIfNotPresent=X-Request-Example:ValueB, X-Request-Second-Example:ValueD