Skip to content

Commit

Permalink
Fix GRPC dependencies for GRPCApplicationTests (#3157)
Browse files Browse the repository at this point in the history
The main fix is bumping GRPC to 1.59.1, for some reason 1.59.0 fails.
Additionally,
* Use same GRPC version for SCG runtime and proto code generation.
* The protobuf compiler version is set with a version to help bumping.
  • Loading branch information
abelsromero authored Dec 2, 2023
1 parent 2f39ba7 commit 592cc39
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions spring-cloud-gateway-integration-tests/grpc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
<description>Spring Cloud Gateway gRPC Integration Test</description>

<properties>
<grpc.version>1.59.0</grpc.version>
<protoc.version>3.25.1</protoc.version>
<grpc.version>1.59.1</grpc.version>
</properties>

<parent>
Expand Down Expand Up @@ -112,9 +113,9 @@
<artifactId>protobuf-maven-plugin</artifactId>
<version>0.6.1</version>
<configuration>
<protocArtifact>com.google.protobuf:protoc:3.19.4:exe:${os.detected.classifier}</protocArtifact>
<protocArtifact>com.google.protobuf:protoc:${protoc.version}:exe:${os.detected.classifier}</protocArtifact>
<pluginId>grpc-java</pluginId>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.44.0:exe:${os.detected.classifier}</pluginArtifact>
<pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}</pluginArtifact>
</configuration>
<executions>
<execution>
Expand Down

0 comments on commit 592cc39

Please sign in to comment.