Removed the default registration of the IHelpProvider #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1313
Changes
This was a bit more complicated than I expected:
After implementing the changes discussed in #1313 (comment) some of our own tests failed because the
FakeTypeRegistrar
/FakeTypeResolver
did not adhere to our assumptions.Thus, I created a unit test that covers the
FakeTypeRegistrar
using theTypeRegistrarBaseTests
and resolved all issues accordingly.Also, there was a minor issue in the
ComponentRegistry
that arose when mixingRegister
,RegisterInstance
andRegisterLazy
- not sure if mixingRegister
withRegisterInstance
while using the same interface is an issue that will occur in the "real world", but it's fixed now 😄Also there was something going on with line endings in
CommandExecutor
, not sure why that was so.